[11.x] Register console commands, paths and routes after the app is booted #50738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
changed the title
crynobone
added a commit
that referenced
this pull request
Mar 25, 2024
This also apply the changes from PR #50738 for `withCommandRouting()` method. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
taylorotwell
pushed a commit
that referenced
this pull request
Mar 25, 2024
* [11.x] Fixes `ApplicationBuilder::withCommandRouting()` usage. This also apply the changes from PR #50738 for `withCommandRouting()` method. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Apply fixes from StyleCI * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip * wip --------- Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During new approach for application bootstrap, console kernel was loading commands, paths and routes shortly after resolving. At this moment,
bootstrap/providers.phpwere not loaded yet.Now kernel is loading resources after app is booted and ready to work.
I believe that tests are not needed at all here. It simply make sense.
This pull request is resolving issue: #50716